Skip to content

fix(entity-joiner): support for metric requests #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2022

Conversation

skjindal93
Copy link
Contributor

No description provided.

@skjindal93 skjindal93 requested a review from a team as a code owner January 6, 2022 10:22
suresh-prakash
suresh-prakash previously approved these changes Jan 6, 2022
suresh-prakash
suresh-prakash previously approved these changes Jan 7, 2022
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #127 (d4dfe6c) into main (b74212b) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #127      +/-   ##
============================================
+ Coverage     22.91%   23.05%   +0.13%     
  Complexity       75       75              
============================================
  Files            65       65              
  Lines          1680     1683       +3     
  Branches         52       52              
============================================
+ Hits            385      388       +3     
  Misses         1286     1286              
  Partials          9        9              
Flag Coverage Δ
unit 23.05% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...phql/entity/joiner/DefaultEntityJoinerBuilder.java 88.42% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b74212b...d4dfe6c. Read the comment docs.

@github-actions

This comment has been minimized.

@skjindal93 skjindal93 merged commit 330cb6d into main Jan 7, 2022
@skjindal93 skjindal93 deleted the support+metric+requests+entity+joiner branch January 7, 2022 13:12
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Unit Test Results

11 files  ±0  11 suites  ±0   12s ⏱️ -1s
24 tests ±0  24 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 330cb6d. ± Comparison against base commit b74212b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants