Skip to content

feat(entity-joiner): support for fixed time range argument #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 29, 2021

Conversation

skjindal93
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #126 (f187730) into main (e3b2361) will decrease coverage by 0.07%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #126      +/-   ##
============================================
- Coverage     22.98%   22.91%   -0.08%     
  Complexity       75       75              
============================================
  Files            65       65              
  Lines          1679     1680       +1     
  Branches         52       52              
============================================
- Hits            386      385       -1     
- Misses         1284     1286       +2     
  Partials          9        9              
Flag Coverage Δ
unit 22.91% <33.33%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...phql/entity/joiner/DefaultEntityJoinerBuilder.java 88.13% <33.33%> (-1.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3b2361...f187730. Read the comment docs.

@github-actions

This comment has been minimized.

suresh-prakash
suresh-prakash previously approved these changes Dec 29, 2021
@github-actions

This comment has been minimized.

suresh-prakash
suresh-prakash previously approved these changes Dec 29, 2021
@github-actions

This comment has been minimized.

@skjindal93 skjindal93 merged commit b74212b into main Dec 29, 2021
@skjindal93 skjindal93 deleted the time+range+entity+joiner branch December 29, 2021 15:22
@github-actions
Copy link

Unit Test Results

11 files  ±0  11 suites  ±0   11s ⏱️ -1s
24 tests ±0  24 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b74212b. ± Comparison against base commit e3b2361.

skjindal93 pushed a commit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants