Skip to content

fix: update submodule for log4j fix #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2021
Merged

fix: update submodule for log4j fix #118

merged 1 commit into from
Dec 10, 2021

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Update vulnerable log4j

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner December 10, 2021 16:00
@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #118 (654dc47) into main (95cb82f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #118   +/-   ##
=========================================
  Coverage     23.03%   23.03%           
  Complexity       75       75           
=========================================
  Files            65       65           
  Lines          1680     1680           
  Branches         52       52           
=========================================
  Hits            387      387           
  Misses         1284     1284           
  Partials          9        9           
Flag Coverage Δ
unit 23.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95cb82f...654dc47. Read the comment docs.

@tim-mwangi
Copy link
Contributor

I'm surprised this one does not declare the dependency directly.

@aaron-steinfeld
Copy link
Contributor Author

I'm surprised this one does not declare the dependency directly.

It uses a dependency platform declared in core to share versions - so the dependency in here is declared without a version.

runtimeOnly("org.apache.logging.log4j:log4j-slf4j-impl")

@aaron-steinfeld aaron-steinfeld merged commit e89adfe into main Dec 10, 2021
@aaron-steinfeld aaron-steinfeld deleted the update-log4j branch December 10, 2021 16:09
@github-actions
Copy link

Unit Test Results

11 files  ±0  11 suites  ±0   12s ⏱️ -4s
24 tests ±0  24 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e89adfe. ± Comparison against base commit 95cb82f.

skjindal93 pushed a commit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants