AVGRATE changes #110
Merged
AVGRATE changes #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #110 +/- ##
=========================================
Coverage 22.98% 22.98%
Complexity 75 75
=========================================
Files 65 65
Lines 1679 1679
Branches 52 52
=========================================
Hits 386 386
Misses 1284 1284
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
requested changes
Oct 29, 2021
|
We don't verify it. Our normal check( which is missing also and I will add) verifies that it's on main, which wouldn't have caught this. I forgot we don't enforce that it doesn't move backwards since that would prevent reverting. |
|
@sarthak77 there are some conflicts on hypetrace-core-graphql, can you retry updating sub-module? |
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
Nov 1, 2021
skjindal93
pushed a commit
that referenced
this pull request
Jun 21, 2024
* feat: add distinct aggregation * add DISTINCT_ARRAY operator * update attribute service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref issue : hypertrace/hypertrace#314