Skip to content

fix(entity): query labels attribute, if requested #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

skjindal93
Copy link
Contributor

The labels attribute was getting requested from attribute for an entity, even though the labels field wasn't requested in the selection set, leading to missing labels attribute errors for entity type for which the labels attribute doesn't exist

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #106 (70066a1) into main (13ea3e4) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #106      +/-   ##
============================================
- Coverage     21.67%   21.64%   -0.03%     
  Complexity       67       67              
============================================
  Files            64       64              
  Lines          1661     1663       +2     
  Branches         54       54              
============================================
  Hits            360      360              
- Misses         1293     1295       +2     
  Partials          8        8              
Flag Coverage Δ
unit 21.64% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ql/entity/request/DefaultEntityRequestBuilder.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13ea3e4...70066a1. Read the comment docs.

@github-actions

This comment has been minimized.

@skjindal93 skjindal93 merged commit 3f0989f into main Sep 27, 2021
@skjindal93 skjindal93 deleted the fetch+labels+if+requested branch September 27, 2021 09:29
@github-actions
Copy link

Unit Test Results

10 files  ±0  10 suites  ±0   13s ⏱️ -3s
20 tests ±0  20 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3f0989f. ± Comparison against base commit 13ea3e4.

skjindal93 pushed a commit that referenced this pull request Jun 21, 2024
* refactor: use container-provided channel registry

* fix: update snyk ignore

* ci: update test publish plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants