-
Notifications
You must be signed in to change notification settings - Fork 4
Attribute expressions #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
============================================
- Coverage 59.42% 58.74% -0.68%
- Complexity 236 243 +7
============================================
Files 81 86 +5
Lines 1215 1263 +48
Branches 37 37
============================================
+ Hits 722 742 +20
- Misses 467 494 +27
- Partials 26 27 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall, lgtm. Had a scan once at a high level. Will check one more time, but we can merge this for now.
@hypertrace/graphql review please. |
Description
Add support to GQL for receiving and writing attribute Expressions
Testing
Updated tests, added some UTs, verified everything E2E
Checklist:
Part of hypertrace/hypertrace-ui#1099