Skip to content

Attribute expressions #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 7, 2022
Merged

Attribute expressions #91

merged 8 commits into from
Jan 7, 2022

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Add support to GQL for receiving and writing attribute Expressions

Testing

Updated tests, added some UTs, verified everything E2E

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Part of hypertrace/hypertrace-ui#1099

@aaron-steinfeld aaron-steinfeld marked this pull request as ready for review January 6, 2022 05:23
@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner January 6, 2022 05:23
@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #91 (af5b41e) into main (a89535a) will decrease coverage by 0.67%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #91      +/-   ##
============================================
- Coverage     59.42%   58.74%   -0.68%     
- Complexity      236      243       +7     
============================================
  Files            81       86       +5     
  Lines          1215     1263      +48     
  Branches         37       37              
============================================
+ Hits            722      742      +20     
- Misses          467      494      +27     
- Partials         26       27       +1     
Flag Coverage Δ
unit 58.74% <42.85%> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tion/AttributeExpressionDeserializationConfig.java 0.00% <0.00%> (ø)
...n/deserialization/CommonDeserializationModule.java 0.00% <0.00%> (ø)
...alization/FilterArgumentDeserializationConfig.java 82.35% <0.00%> (-5.15%) ⬇️
.../core/graphql/common/request/AttributeRequest.java 0.00% <0.00%> (ø)
...l/common/schema/attributes/AttributeQueryable.java 0.00% <0.00%> (ø)
...n/utils/attributes/DefaultAttributeAssociator.java 0.00% <0.00%> (ø)
...e/graphql/utils/gateway/AttributeMapConverter.java 0.00% <0.00%> (ø)
...ce/core/graphql/utils/gateway/FilterConverter.java 0.00% <0.00%> (ø)
...core/graphql/utils/gateway/GatewayUtilsModule.java 0.00% <0.00%> (ø)
.../utils/gateway/OrderByExpressionListConverter.java 0.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a89535a...af5b41e. Read the comment docs.

Copy link
Contributor

@kotharironak kotharironak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall, lgtm. Had a scan once at a high level. Will check one more time, but we can merge this for now.

@aaron-steinfeld
Copy link
Contributor Author

@hypertrace/graphql review please.

@aaron-steinfeld aaron-steinfeld merged commit 7be2e98 into main Jan 7, 2022
@aaron-steinfeld aaron-steinfeld deleted the attribute-expressions branch January 7, 2022 13:03
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Unit Test Results

31 files  ±0  31 suites  ±0   32s ⏱️ -6s
97 tests +2  97 ✔️ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 7be2e98. ± Comparison against base commit a89535a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants