Skip to content

refactor: use caching attribute client #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2021

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Remove the custom attribute cache in graphql to use the common caching attribute client instead (which was built much later using the graphql cache as a model). Specifically, this changes over to use the newer unary attribute API instead of the deprecated streaming API.

Updated grpc versions to align, too.

Testing

Updated UTs and manually tested

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner September 1, 2021 22:44
@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #76 (6e3fbf2) into main (2edb271) will increase coverage by 0.03%.
The diff coverage is 65.21%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #76      +/-   ##
============================================
+ Coverage     59.34%   59.38%   +0.03%     
+ Complexity      244      236       -8     
============================================
  Files            81       80       -1     
  Lines          1225     1199      -26     
  Branches         34       34              
============================================
- Hits            727      712      -15     
+ Misses          470      460      -10     
+ Partials         28       27       -1     
Flag Coverage Δ
unit 59.38% <65.21%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../core/graphql/attributes/AttributeStoreModule.java 0.00% <ø> (ø)
...core/graphql/attributes/CachingAttributeStore.java 78.04% <65.21%> (-17.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2edb271...6e3fbf2. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Unit Test Results

30 files  ±0  30 suites  ±0   32s ⏱️ -12s
91 tests  - 6  91 ✔️  - 6  0 💤 ±0  0 ❌ ±0 

Results for commit d941520. ± Comparison against base commit 2edb271.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants