-
Notifications
You must be signed in to change notification settings - Fork 4
feat: adding consumer support for new traces/spans api #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -16,7 +16,7 @@ dependencies { | |||
api("org.hypertrace.core.grpcutils:grpc-context-utils:0.12.1") | |||
api("org.hypertrace.core.grpcutils:grpc-client-utils:0.12.1") | |||
api("org.hypertrace.core.grpcutils:grpc-client-rx-utils:0.12.1") | |||
api("org.hypertrace.gateway.service:gateway-service-api:0.2.25") | |||
api("org.hypertrace.gateway.service:gateway-service-api:0.3.0-SNAPSHOT") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once I merged the gateway-service PR and cut the release, will update the appropriate version here.
return zip( | ||
resultSetRequestBuilder.build( | ||
context, HypertraceCoreAttributeScopeString.SPAN, arguments, spanAttributeExpressions), | ||
logEventAttributeRequestBuilder.buildAttributeRequest(context, logAttributeExpressions), | ||
(resultSetRequest, logEventAttributeRequest) -> | ||
new DefaultSpanRequest(context, resultSetRequest, logEventAttributeRequest)); | ||
new DefaultSpanRequest(context, resultSetRequest, logEventAttributeRequest, false)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used via ExportSpans API, and ExportSpanResult
doesn't extends ResultSet
. It doesn't support total.
Ref: https://github.com/hypertrace/hypertrace-core-graphql/blob/main/hypertrace-core-graphql-span-schema/src/main/java/org/hypertrace/core/graphql/span/schema/ExportSpanResult.java#L15C1-L15C1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used via ExportSpans API, and ExportSpanResult doesn't extends ResultSet. It doesn't support total.
We can add it as a comment to explain why fetchTotal is set to false here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good (apart from @satish-mittal's review comment)
Codecov Report
@@ Coverage Diff @@
## main #140 +/- ##
=========================================
Coverage 57.57% 57.57%
Complexity 264 264
=========================================
Files 91 91
Lines 1445 1445
Branches 42 42
=========================================
Hits 832 832
Misses 583 583
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Description
As part of supporting
fetch_total
as request in spans/traces API, this PR makes the corresponding changes at client side.Ref PR: hypertrace/gateway-service#169