fix: unknown scalar not handling variable values #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #127 +/- ##
============================================
+ Coverage 57.13% 57.48% +0.34%
Complexity 264 264
============================================
Files 90 90
Lines 1437 1437
Branches 42 42
============================================
+ Hits 821 826 +5
+ Misses 587 581 -6
- Partials 29 30 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tim-mwangi
reviewed
Feb 3, 2023
|
|
||
| @Test | ||
| void canConvertFromValue() { | ||
| // A dumb bug requires a dumb test |
tim-mwangi
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The parseValue version of the unknown scalar was not correctly handling the raw values that are given when using a variable for an unknown value. It treated all inputs as AST objects. It now echos them back out, as unknown values have no specific type and they're left to the code to determine. Also fixed a bug where an error was returned rather than thrown which was hiding this issue in the past.
Testing
Added Unit tests and verified in local instance
Checklist: