Skip to content

refactor: update core gql libs #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Conversation

aaron-steinfeld
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld commented Oct 6, 2022

Description

Updating the main GQL libs, which included a few breaking changes. The two main ones here are

  • Schema Validation now requires every object to have at least one type. This makes sense, but causes issues with how we build partial schemas then merge them. Sidestepped the issue by adding placeholders to root schema so every partial schema passes validation, then stripping them out at the end (before validating one last time).
  • The Context types were renamed and move around a bit. A few types were changed and fields removed. Updated our context based off it to extend the built in one and adjusted things here a bit.

Testing

Unit and ran E2E

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner October 6, 2022 22:36
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Test Results

98 tests  ±0   98 ✔️ ±0   29s ⏱️ -4s
32 suites ±0     0 💤 ±0 
32 files   ±0     0 ±0 

Results for commit c19f828. ± Comparison against base commit ad5bb7a.

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #114 (c19f828) into main (ad5bb7a) will increase coverage by 0.62%.
The diff coverage is 96.29%.

@@             Coverage Diff              @@
##               main     #114      +/-   ##
============================================
+ Coverage     58.35%   58.98%   +0.62%     
- Complexity      256      264       +8     
============================================
  Files            87       87              
  Lines          1323     1336      +13     
  Branches         39       40       +1     
============================================
+ Hits            772      788      +16     
+ Misses          521      517       -4     
- Partials         30       31       +1     
Flag Coverage Δ
unit 58.98% <96.29%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../schema/registry/DefaultGraphQlSchemaRegistry.java 0.00% <ø> (ø)
...ce/core/graphql/schema/registry/DefaultSchema.java 75.00% <ø> (+75.00%) ⬆️
.../schema/registry/GraphQlAnnotatedSchemaMerger.java 97.33% <95.45%> (-0.82%) ⬇️
...l/context/DefaultGraphQlRequestContextBuilder.java 81.08% <100.00%> (-1.15%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants