Skip to content

feat: Add DISTINCT_ARRAY aggregation type #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2022

Conversation

SrikarMannepalli
Copy link
Contributor

@SrikarMannepalli SrikarMannepalli commented Sep 19, 2022

Description

Adds DISTINCT_ARRAY aggregation type

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link

Test Results

97 tests  ±0   97 ✔️ ±0   27s ⏱️ ±0s
32 suites ±0     0 💤 ±0 
32 files   ±0     0 ±0 

Results for commit a329e18. ± Comparison against base commit 7b93309.

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #110 (a329e18) into main (7b93309) will decrease coverage by 0.14%.
The diff coverage is 28.57%.

@@             Coverage Diff              @@
##               main     #110      +/-   ##
============================================
- Coverage     58.37%   58.22%   -0.15%     
  Complexity      255      255              
============================================
  Files            87       87              
  Lines          1314     1319       +5     
  Branches         39       39              
============================================
+ Hits            767      768       +1     
- Misses          517      521       +4     
  Partials         30       30              
Flag Coverage Δ
unit 58.22% <28.57%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/graphql/attributes/AttributeModelTranslator.java 65.85% <0.00%> (-1.65%) ⬇️
...ommon/schema/attributes/MetricAggregationType.java 0.00% <0.00%> (ø)
.../AttributeModelMetricAggregationTypeConverter.java 0.00% <0.00%> (ø)
...ils/attributes/MetricAggregationTypeConverter.java 0.00% <0.00%> (ø)
...ttributes/AttributeModelMetricAggregationType.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SrikarMannepalli SrikarMannepalli merged commit 3584f91 into main Sep 19, 2022
@SrikarMannepalli SrikarMannepalli deleted the add-distinct-aggregation-type branch September 19, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants