Skip to content

refactor: add request id, change how registry is provided #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

aaron-steinfeld
Copy link
Contributor

Description

  • Add request ID, mapped to the new grpc request id
  • Change how grpc channel registry is provided to make it more... guicey.

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner September 9, 2022 15:17
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Test Results

97 tests  +1   97 ✔️ +1   26s ⏱️ ±0s
32 suites ±0     0 💤 ±0 
32 files   ±0     0 ±0 

Results for commit 0cbad43. ± Comparison against base commit b3f39e7.

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #107 (0cbad43) into main (b3f39e7) will increase coverage by 0.18%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##               main     #107      +/-   ##
============================================
+ Coverage     58.18%   58.37%   +0.18%     
  Complexity      255      255              
============================================
  Files            87       87              
  Lines          1313     1314       +1     
  Branches         39       39              
============================================
+ Hits            764      767       +3     
+ Misses          519      517       -2     
  Partials         30       30              
Flag Coverage Δ
unit 58.37% <71.42%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...graphql/utils/grpc/DefaultGrpcChannelRegistry.java 80.00% <ø> (ø)
...ace/core/graphql/utils/grpc/GraphQlGrpcModule.java 0.00% <0.00%> (ø)
...l/context/DefaultGraphQlRequestContextBuilder.java 82.22% <50.00%> (-1.50%) ⬇️
...graphql/utils/grpc/PlatformGrpcContextBuilder.java 95.65% <100.00%> (+0.19%) ⬆️
...rg/hypertrace/core/graphql/impl/GraphQlModule.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-steinfeld aaron-steinfeld merged commit fd5b13d into main Sep 9, 2022
@aaron-steinfeld aaron-steinfeld deleted the grpc-changes branch September 9, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants