refactor: use container-provided channel registry #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-steinfeld
commented
Aug 2, 2022
|
|
||
| @Inject | ||
| DefaultGrpcChannelRegistry(GraphQlServiceLifecycle serviceLifecycle) { | ||
| serviceLifecycle.shutdownCompletion().thenRun(this.delegate::shutdown); |
There was a problem hiding this comment.
No longer required, the channel registry is managed by the container.
Codecov Report
@@ Coverage Diff @@
## main #106 +/- ##
============================================
- Coverage 58.36% 58.18% -0.18%
Complexity 255 255
============================================
Files 87 87
Lines 1309 1313 +4
Branches 39 39
============================================
Hits 764 764
- Misses 515 519 +4
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
surajpuvvada
previously approved these changes
Aug 2, 2022
surajpuvvada
approved these changes
Aug 2, 2022
d-trace
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small refactor to use the container's channel registry rather than building our own internally