Skip to content

feat: add CONTAINS_KEY_LIKE operator #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

GurtejSohi
Copy link
Contributor

Description

Propagating the changes from gateway-service(hypertrace/gateway-service#136) to here, this PR adds CONTAINS_KEY_LIKE operator for doing a regex based search on map fields (on map key column).

@GurtejSohi GurtejSohi requested a review from a team as a code owner June 28, 2022 19:42
@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #104 (6a61766) into main (5b612df) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main     #104      +/-   ##
============================================
- Coverage     58.37%   58.36%   -0.02%     
  Complexity      255      255              
============================================
  Files            87       87              
  Lines          1307     1309       +2     
  Branches         39       39              
============================================
+ Hits            763      764       +1     
- Misses          514      515       +1     
  Partials         30       30              
Flag Coverage Δ
unit 58.36% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../core/graphql/utils/gateway/OperatorConverter.java 0.00% <0.00%> (ø)
...a/results/arguments/filter/FilterOperatorType.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b612df...6a61766. Read the comment docs.

@GurtejSohi GurtejSohi merged commit 47b1e94 into main Jun 29, 2022
@GurtejSohi GurtejSohi deleted the add-contains-key-like-operator branch June 29, 2022 05:51
@github-actions
Copy link

Unit Test Results

32 files  ±0  32 suites  ±0   33s ⏱️ ±0s
98 tests ±0  98 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 47b1e94. ± Comparison against base commit 5b612df.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants