Skip to content

chore: upgrade to 17 - BREAKING CHANGE #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2024
Merged

chore: upgrade to 17 - BREAKING CHANGE #978

merged 4 commits into from
Apr 24, 2024

Conversation

adisreyaj
Copy link
Contributor

Description

Upgrade Angular to v17

Copy link

github-actions bot commented Apr 24, 2024

Test Results

53 tests   53 ✅  16s ⏱️
15 suites   0 💤
 2 files     0 ❌

Results for commit 33bcfdd.

♻️ This comment has been updated with latest results.

@adisreyaj adisreyaj marked this pull request as ready for review April 24, 2024 06:15
@adisreyaj adisreyaj requested a review from a team as a code owner April 24, 2024 06:15
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (71a77a4) to head (33bcfdd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #978   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files          49       49           
  Lines         607      607           
  Branches       38       35    -3     
=======================================
  Hits          605      605           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mark the change as breaking. should be a major version bump

@aaron-steinfeld
Copy link
Contributor

Also as long as you're in here, do you mind updating the GHA config to bump some of the deprecated action versions:
image

BREAKING CHANGE: Requires min Angular version 17
Co-authored-by: Aaron Steinfeld <[email protected]>
@adisreyaj adisreyaj changed the title chore: upgrade to 17 chore: upgrade to 17 - BREAKING CHANGE Apr 24, 2024
@adisreyaj adisreyaj merged commit 99dfc1e into main Apr 24, 2024
@adisreyaj adisreyaj deleted the chore/ng-17 branch April 24, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants