Add spot deploy api #104
Open
Add spot deploy api #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traderben
requested changes
Jan 17, 2025
There was a problem hiding this comment.
Thanks for putting this together. If we were to merge this we'll need to add more comments to the example and method. Also deploying spot is a multistep process, one of which is userGenesis. It's ok if you don't want to add methods for all the steps, but we can't have the method be called spot_deploy in case we add support for the other steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
spot_deploytoExchangeandexamples/basic_spot_deploy.pyto supportspotDeployAPI call corresponding to this doc.