Fixes issues from merge and splits trait to expose only public method #994
+97
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simongdavies
added
the
kind/refactor
simongdavies
added
the
kind/dependencies
simongdavies
requested review from
dblnz,
devigned,
jprendes,
marosset and
syntactically
as code owners
simongdavies
removed
the
kind/refactor
jsturtevant
previously approved these changes
Oct 28, 2025
Signed-off-by: Simon Davies <[email protected]>
ludfjig
previously approved these changes
Oct 28, 2025
Contributor
ludfjig
left a comment
ludfjig
left a comment
There was a problem hiding this comment.
LGTM, this is more or less what I was thinking too
simongdavies
dismissed stale reviews from ludfjig and jsturtevant
via
1a9cc60
simongdavies
force-pushed
the
fix-merge
branch
from
7843269 to
1a9cc60
Compare
simongdavies
commented
Oct 28, 2025
ludfjig
approved these changes
Oct 28, 2025
dblnz
reviewed
Oct 28, 2025
dblnz
approved these changes
Oct 28, 2025
simongdavies
added a commit
to ludfjig/hyperlight
that referenced
this pull request
Oct 29, 2025
…hyperlight-dev#994) Signed-off-by: Simon Davies <[email protected]>
simongdavies
added a commit
to ludfjig/hyperlight
that referenced
this pull request
Oct 29, 2025
…hyperlight-dev#994) Signed-off-by: Simon Davies <[email protected]>
simongdavies
added a commit
to ludfjig/hyperlight
that referenced
this pull request
Oct 29, 2025
…hyperlight-dev#994) Signed-off-by: Simon Davies <[email protected]>
simongdavies
added a commit
to ludfjig/hyperlight
that referenced
this pull request
Oct 29, 2025
…hyperlight-dev#994) Signed-off-by: Simon Davies <[email protected]>
simongdavies
added a commit
that referenced
this pull request
Oct 29, 2025
* Add poison state to sandbox to prevent misuse (#931) Signed-off-by: Ludvig Liljenberg <[email protected]> * Fixes a race condition in killing Sandboxes (#959) Signed-off-by: Simon Davies <[email protected]> * Update common workflow to 1.8.0 Signed-off-by: Simon Davies <[email protected]> * Fixes issues from merge and splits trait to expose only public method (#994) Signed-off-by: Simon Davies <[email protected]> * updates to change log and crate version for v0.9.1 Signed-off-by: Simon Davies <[email protected]> --------- Signed-off-by: Ludvig Liljenberg <[email protected]> Signed-off-by: Simon Davies <[email protected]> Co-authored-by: Simon Davies <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge issues with the mshv2 PR messed things up, we also took the opportunity to refactor the
InterruptHandletrait so we only exposed public methods