Make the component macros support passing host resources to guests #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntactically
requested review from
danbugs,
ludfjig,
dblnz,
devigned,
marosset,
jprendes and
simongdavies
as code owners
syntactically
force-pushed
the
lm/pass-host-resources-to-guests
branch
from
63e5d7d to
e57d266
Compare
…unctions Previously, the guest could acquire and use host resources through host function calls, but the original call from the host into the guest could not pass in owned or borrowed host resources. This commit fixes in a number of bugs in order to make that possible, and adds rudimentary tests to witguest. Signed-off-by: Lucy Menon <[email protected]>
Signed-off-by: Lucy Menon <[email protected]>
Previously, it still passed an extra config parameter when running bench-ci, which caused issues. Signed-off-by: Lucy Menon <[email protected]>
syntactically
force-pushed
the
lm/pass-host-resources-to-guests
branch
from
e57d266 to
b7e0481
Compare
|
I ran the updated code against the wasi:http demo and it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix a bunch of issues including those that #829 was getting at.