Build c guests as required by benchmarks #822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
requested review from
danbugs,
dblnz,
devigned,
syntactically,
marosset,
jprendes and
simongdavies
as code owners
ludfjig
requested review from
Copilot
and removed request for
devigned,
simongdavies,
jprendes,
dblnz,
marosset,
danbugs and
syntactically
There was a problem hiding this comment.
Pull Request Overview
This PR adds C guest binary build support to the GitHub Actions workflow for benchmarks, addressing the requirement introduced in #778 where benchmarks started using C guest binaries but only Rust binaries were being built and made available.
- Updates the build workflow to compile both Rust and C guest binaries using
just guests - Creates separate artifact uploads for Rust and C guest binaries
- Updates the benchmark workflow to download and copy both types of guest binaries
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/dep_build_guest_binaries.yml |
Changes from Rust-only guest build to building both Rust and C guests with separate artifact uploads |
.github/workflows/Benchmarks.yml |
Updates to download and copy both Rust and C guest binaries for benchmark execution |
ludfjig
added
kind/bugfix
Signed-off-by: Ludvig Liljenberg <[email protected]>
ludfjig
force-pushed
the
build_guest_step
branch
from
74f7737 to
9fe350e
Compare
jsturtevant
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#778 started using c guest binaries in benchmarks. But only rust binaries are available for the CreateRelease/Benchmarks jobs. This PR build c guest now as well.
Example of failed run: https://github.com/hyperlight-dev/hyperlight/actions/runs/17218708134/job/48851092585