Skip to content

remove .vscode settings #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2024
Merged

remove .vscode settings #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23a01a8
remove .vscode settings
simongdavies Nov 18, 2024
e68bd3e
additional changes and addressing feedback
simongdavies Nov 18, 2024
639c514
Update .devcontainer/Dockerfile
simongdavies Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,6 @@ RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y \
&& rustup target add x86_64-unknown-linux-gnu \
&& rustup target add x86_64-unknown-none \
&& rustup target add x86_64-pc-windows-msvc \
&& rustup toolchain add nightly-x86_64-unknown-linux-gnu \
&& cargo install just

7 changes: 6 additions & 1 deletion .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@
"ms-vscode.cmake-tools",
"rust-lang.rust-analyzer",
"vadimcn.vscode-lldb"
]
],
"settings": {
"rust-analyzer.rustfmt.extraArgs": [
"+nightly" // required for rustfmt.toml which uses nightly features
]
}
}
}
}
4 changes: 0 additions & 4 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,10 +448,6 @@ $RECYCLE.BIN/
## Visual Studio Code
##
.vscode/*
!.vscode/settings.json
!.vscode/tasks.json
!.vscode/launch.json
!.vscode/extensions.json

/downloads

Expand Down
50 changes: 0 additions & 50 deletions .vscode/launch.json
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions .vscode/settings.json
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ All contributions come through pull requests. To submit a proposed change, we re
#### Use work-in-progress PRs for early feedback

A good way to communicate before investing too much time is to create a "Work-in-progress" PR and share it with your reviewers. The standard way of doing this is to add a "[WIP]" prefix in your PR's title and open the pull request as a draft.

### Developer Certificate of Origin: Signing your work

#### Every commit needs to be signed
Expand Down Expand Up @@ -82,3 +83,7 @@ git push --force-with-lease <remote-name> <branch-name>
```

*Credit: This doc was cribbed from Dapr.*

### Rust Analyzer

If you are using the [Rust Analyzer](https://rust-analyzer.github.io/manual.html) then you may need to set the configuration option `rust-analyzer.rustfmt.extraArgs` to `["+nightly"]` to ensure that formatting works correctly as this project has a [`rustfmt.toml`](./rustfmt.toml) file that uses nightly features.
Loading