gdb: fix sandbox function cancellation when gdb enabled #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblnz
requested review from
danbugs,
ludfjig,
devigned,
syntactically,
marosset,
jprendes and
simongdavies
as code owners
- when the `gdb` features is enabled, the EINTR exit reason was always mapped to a Debug stop reason. With the new changes to the threading model, the EINTR exit reason can be a result of a cancel request. We need to first check if a cancel was requested, if not, it means a sandbox with debugging enabled was issued an interrupt request from the debugger - adds a way for a sandbox under debugging to remain attached to the debugger when a crash happens. This way the crash can be inspected. This forbids continuing execution and writing to memory and registers. Signed-off-by: Doru Blânzeanu <[email protected]>
dblnz
force-pushed
the
gdb-crash-reporting-improvements
branch
from
88d2adb to
c7232c8
Compare
simongdavies
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gdbfeatures is enabled, the EINTR exit reason was always mapped to a Debug stop reason. With the new changes to the threading model, the EINTR exit reason can be a result of a cancel request. We need to first check if a cancel was requested, if not, it means a sandbox with debugging enabled was issued an interrupt request from the debugger