Skip to content

Remove version number from hyperlight-testing crate dependency #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

Remove version number from hyperlight-testing crate dependency #588

merged 1 commit into from
Jun 9, 2025

Conversation

simongdavies
Copy link
Contributor

In #580 a version number was adding to the hyperlight-testing dependency. This caused the Cargo pubish job for the last release to fail.

This PR removes the version number so we don't have to publish the hyperlight-testing crate

@simongdavies simongdavies added the kind/bugfix For PRs that fix bugs label Jun 9, 2025
@simongdavies simongdavies enabled auto-merge (squash) June 9, 2025 08:43
@jprendes
Copy link
Contributor

jprendes commented Jun 9, 2025

I think we also need to remove the

version.workspace = true

from src/hyperlight_testing/Cargo.toml

@simongdavies
Copy link
Contributor Author

simongdavies commented Jun 9, 2025 •
edited
Loading

I think we also need to remove the

version.workspace = true

from src/hyperlight_testing/Cargo.toml

How come, I did a dry run publish and it worked

@jprendes
Copy link
Contributor

jprendes commented Jun 9, 2025

#580 added the version to src/hyperlight_testing/Cargo.toml as well.
Removing it from the workspace might be enough to fix the issue, but I think we should also remove it from the crate's toml file.
If dry run is happy, then it's just a nit. I let you decide if you want to remove it now or not :-)

jprendes
jprendes previously approved these changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jprendes
jprendes approved these changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simongdavies simongdavies merged commit b0d395d into hyperlight-dev:main Jun 9, 2025
29 checks passed
@simongdavies simongdavies mentioned this pull request Jun 9, 2025
Merged
simongdavies added a commit to simongdavies/hyperlight that referenced this pull request Jun 9, 2025
@simongdavies
Remove version number from hypelright-testing crate dependency (hyper…
24e65e8 
…light-dev#588)

Signed-off-by: Simon Davies <[email protected]>
simongdavies added a commit that referenced this pull request Jun 9, 2025
@simongdavies
Remove version number from hyperlight-testing crate dependency (#588) (…
3c1cc18 
…#589)

Signed-off-by: Simon Davies <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprendes jprendes jprendes approved these changes

@danbugs danbugs Awaiting requested review from danbugs danbugs is a code owner

@ludfjig ludfjig Awaiting requested review from ludfjig ludfjig is a code owner

@dblnz dblnz Awaiting requested review from dblnz dblnz is a code owner

@devigned devigned Awaiting requested review from devigned devigned is a code owner

@syntactically syntactically Awaiting requested review from syntactically syntactically is a code owner

@marosset marosset Awaiting requested review from marosset marosset is a code owner

Assignees
No one assigned
Labels
kind/bugfix For PRs that fix bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simongdavies @jprendes