Skip to content

Don't include PRs with kind/dependencies in wrong changelog category #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

Don't include PRs with kind/dependencies in wrong changelog category #539

merged 1 commit into from
May 29, 2025

Conversation

ludfjig
Copy link
Contributor

@ludfjig ludfjig commented May 28, 2025 •
edited
Loading

Running just create-release-notes v0.4.0 incorrectly includes dependecy-prs in the category that should exclude the dependencies PR, see the following "bump" prs:

### Full Changelog (excl. dependencies)
* Update the README & Code of conduct sections to the CNCF CoC by @benazirk in https://github.com/hyperlight-dev/hyperlight/pull/383
* changelog: fix version typo by @dblnz in https://github.com/hyperlight-dev/hyperlight/pull/388
* Fix dependabot by @simongdavies in https://github.com/hyperlight-dev/hyperlight/pull/390
* Bump windows-result from 0.3.1 to 0.3.2 by @dependabot in https://github.com/hyperlight-dev/hyperlight/pull/395
* Bump opentelemetry-semantic-conventions from 0.28.0 to 0.29.0 by @dependabot in https://github.com/hyperlight-dev/hyperlight/pull/391
* Bump crate-ci/typos from 1.30.3 to 1.31.1 by @dependabot in https://github.com/hyperlight-dev/hyperlight/pull/387
* Bump windows-version from 0.1.3 to 0.1.4 by @dependabot in https://github.com/hyperlight-dev/hyperlight/pull/392
* Bump tempfile from 3.19.0 to 3.19.1 by @dependabot in https://github.com/hyperlight-dev/hyperlight/pull/394
* Bump windows from 0.60.0 to 0.61.1 by @dependabot in https://github.com/hyperlight-dev/hyperlight/pull/393

@ludfjig
Don't include PRs with kind/dependencies label in category 'Full Chan…
c088132 
…gelog (excl. dependencies)'

Signed-off-by: Ludvig Liljenberg <[email protected]>
@ludfjig ludfjig mentioned this pull request May 28, 2025
Merged
@ludfjig ludfjig added kind/bugfix For PRs that fix bugs area/infrastructure Concerns infrastructure rather than core functionality labels May 28, 2025
@ludfjig ludfjig changed the title Don't include PRs with kind/dependencies in wrong category Don't include PRs with kind/dependencies in wrong changelog category May 28, 2025
@ludfjig ludfjig merged commit 54e4a02 into hyperlight-dev:main May 29, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsturtevant jsturtevant jsturtevant approved these changes

@marosset marosset marosset approved these changes

@danbugs danbugs Awaiting requested review from danbugs danbugs is a code owner

@dblnz dblnz Awaiting requested review from dblnz dblnz is a code owner

@devigned devigned Awaiting requested review from devigned devigned is a code owner

@syntactically syntactically Awaiting requested review from syntactically syntactically is a code owner

@jprendes jprendes Awaiting requested review from jprendes jprendes is a code owner

@simongdavies simongdavies Awaiting requested review from simongdavies simongdavies is a code owner

Assignees
No one assigned
Labels
area/infrastructure Concerns infrastructure rather than core functionality kind/bugfix For PRs that fix bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ludfjig @jsturtevant @marosset