Skip to content

Refactor HostFunction #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

Refactor HostFunction #491

merged 1 commit into from
May 15, 2025

Conversation

jprendes
Copy link
Contributor

Some more refactor of HostFunction.
In this PR:

  • the registration can't be made from the function anymore, and has to be done from the sandbox.
  • the registered function can return either the plain type T, or a Result<T>.
  • adds a new ParameterTuple trait that is used to define serializable input to a function.

@jprendes jprendes added kind/refactor For PRs that restructure or remove code without adding new functionality. area/API Related to the API or public interface labels May 14, 2025
@jprendes jprendes force-pushed the host_function_4 branch 2 times, most recently from 7feb6ba to cc2ca52 Compare May 14, 2025 22:44
@jprendes jprendes marked this pull request as ready for review May 14, 2025 23:20
@jprendes
Refactor HostFunction
f3f135a 
Signed-off-by: Jorge Prendes <[email protected]>
@jprendes
Copy link
Contributor Author

@ludfjig @danbugs PTAL, thank! :-)

@jprendes jprendes mentioned this pull request May 15, 2025
Merged
danbugs
danbugs approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@danbugs danbugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jprendes jprendes merged commit d353fc7 into hyperlight-dev:main May 15, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ludfjig ludfjig ludfjig approved these changes

@danbugs danbugs danbugs approved these changes

@dblnz dblnz Awaiting requested review from dblnz dblnz is a code owner

@devigned devigned Awaiting requested review from devigned devigned is a code owner

@syntactically syntactically Awaiting requested review from syntactically syntactically is a code owner

@marosset marosset Awaiting requested review from marosset marosset is a code owner

@simongdavies simongdavies Awaiting requested review from simongdavies simongdavies is a code owner

Assignees

No one assigned

Labels

area/API Related to the API or public interface kind/refactor For PRs that restructure or remove code without adding new functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jprendes @ludfjig @danbugs