Changes to remove build steps for PE formatted guests. #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simongdavies
requested review from
danbugs,
ludfjig,
dblnz,
devigned,
syntactically,
marosset and
jprendes
as code owners
simongdavies
added
kind/enhancement
simongdavies
force-pushed
the
update-ci-and-build-for-pe-guest-removal
branch
2 times, most recently
from
f4f7666 to
eceecd1
Compare
Signed-off-by: Simon Davies <[email protected]>
simongdavies
force-pushed
the
update-ci-and-build-for-pe-guest-removal
branch
from
eceecd1 to
a3525b5
Compare
|
@simongdavies there is still some PE info in the cargo/config.toml for each guest that we can probably remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have removed support for PE formatted guests (#470), we no longer need to build/archive these guests.
This completes the work for issue #470