Skip to content

Improve ergonomics of SupportedParameterType and SupportedReturnType #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

Improve ergonomics of SupportedParameterType and SupportedReturnType #476

merged 1 commit into from
May 8, 2025

Conversation

jprendes
Copy link
Contributor

@jprendes jprendes commented May 8, 2025

This PR:

  • reduces code duplication using macros
  • replaces get_hyperlight_type with a TYPE associated const
  • replaces get_hyperlight_value(&self) with into_value(self), for a better name and avoiding a copy.
  • replaces get_inner(v: XxxValue) with from_value(v: XxxValue), for a better name.

@jprendes jprendes added the kind/refactor For PRs that restructure or remove code without adding new functionality. label May 8, 2025
ludfjig
ludfjig approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@ludfjig ludfjig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean

@jprendes jprendes merged commit 7373501 into hyperlight-dev:main May 8, 2025
38 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludfjig ludfjig ludfjig approved these changes

@danbugs danbugs Awaiting requested review from danbugs danbugs is a code owner

@dblnz dblnz Awaiting requested review from dblnz dblnz is a code owner

@devigned devigned Awaiting requested review from devigned devigned is a code owner

@syntactically syntactically Awaiting requested review from syntactically syntactically is a code owner

@marosset marosset Awaiting requested review from marosset marosset is a code owner

@simongdavies simongdavies Awaiting requested review from simongdavies simongdavies is a code owner

Assignees
No one assigned
Labels
kind/refactor For PRs that restructure or remove code without adding new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jprendes @ludfjig