Add a specific CI job on which we can gate PRs. #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e gating on specific skippable jobs does not work when those jobs are skipped (for example during docs-only PRs) Signed-off-by: Ludvig Liljenberg <[email protected]>
ludfjig
added
the
area/infrastructure
There was a problem hiding this comment.
PR Overview
This PR introduces a new CI job to gate PR merges by ensuring that all key jobs run, even in scenarios like docs-only PRs where some jobs might be skipped.
- Adds a "report-ci-status" job that depends on the results of "docs-pr", "rust", "fuzzing", and "spelling" jobs.
- Implements conditional steps to exit with success or failure based on the results of preceding jobs.
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/ValidatePullRequest.yml | Added the "report-ci-status" job to reliably gate PR merges regardless of skipped jobs. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
marosset
approved these changes
Mar 6, 2025
danbugs
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because gating on specific skippable jobs does not work when those jobs are skipped (for example during docs-only PRs). Inspired by wasmtime's main.yml ci job
See #334 for an docs-only PR where this happened.
