Skip to content

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 20, 2025

% codespell --ignore-words-list=crate,fo,habitant,wit --skip="./NOTICE.txt,./src/hyperlight_guest/third_party/*" --write-changes
https://github.com/codespell-project/codespell

@cclauss cclauss changed the title Fix typo Fix typos discovered by codespell Jan 20, 2025
devigned
devigned previously approved these changes Jan 21, 2025
Copy link
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, TY!

@devigned devigned added the area/documentation Related to documentation label Jan 21, 2025
@simongdavies
Copy link
Contributor

@cclauss Thanks for this, we added a spell checker to our PR validation but it looks like its not picking everything up, maybe we should replace it codespell, @andreiltd what do you think?

simongdavies
simongdavies previously approved these changes Jan 21, 2025
@simongdavies
Copy link
Contributor

@cclauss please could you sign your commit?

@andreiltd
Copy link
Member

@simongdavies Here is a little comparison of spell checking tools: https://github.com/crate-ci/typos/blob/master/docs/comparison.md. It's unfortunate that some typos slip through, of course, but I still think typos is a better tool for the job.

I've proposed to add some of these corrections to typos: crate-ci/typos#1200. We can also add our own corrections to typos.toml.

As for things like dont -> don't see this issue: crate-ci/typos#795

marosset
marosset previously approved these changes Jan 27, 2025
dependabot bot and others added 3 commits January 28, 2025 00:05
Bumps [goblin](https://github.com/m4b/goblin) from 0.9.2 to 0.9.3.
- [Changelog](https://github.com/m4b/goblin/blob/master/CHANGELOG.md)
- [Commits](https://github.com/m4b/goblin/commits/0.9.3)

---
updated-dependencies:
- dependency-name: goblin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [cc](https://github.com/rust-lang/cc-rs) from 1.2.9 to 1.2.10.
- [Release notes](https://github.com/rust-lang/cc-rs/releases)
- [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md)
- [Commits](rust-lang/cc-rs@cc-v1.2.9...cc-v1.2.10)

---
updated-dependencies:
- dependency-name: cc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Christian Clauss <[email protected]>
ludfjig
ludfjig previously approved these changes Jan 28, 2025
@cclauss cclauss dismissed ludfjig’s stale review January 28, 2025 00:56

The merge-base changed after approval.

ludfjig
ludfjig previously approved these changes Jan 28, 2025
@cclauss cclauss dismissed ludfjig’s stale review January 28, 2025 01:02

The merge-base changed after approval.

syntactically
syntactically previously approved these changes Jan 28, 2025
@cclauss cclauss dismissed syntactically’s stale review January 28, 2025 01:17

The merge-base changed after approval.

syntactically
syntactically previously approved these changes Jan 28, 2025
ludfjig
ludfjig previously approved these changes Jan 28, 2025
@cclauss cclauss dismissed stale reviews from ludfjig and syntactically January 28, 2025 01:24

The merge-base changed after approval.

@syntactically syntactically merged commit 5302c77 into hyperlight-dev:main Jan 28, 2025
17 checks passed
@cclauss cclauss deleted the patch-1 branch January 28, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants