Skip to content

Conversation

ludfjig
Copy link
Contributor

@ludfjig ludfjig commented Dec 10, 2024

Adds musl as a git subtree. Adds more of libc, as required by for example a quickjs guest.

The 6 commits does the following

  1. Removes current musl
  2. Adds musl v1.2.5 (latest) as a git subtree (squashed)
  3. Merge commit for git subtree
  4. Removes musl files we don't need
  5. Patches musl for Hyperlight
  6. Updates docs/build.rs/justfiles

[having some problems gpg signing the squash commit...]

@ludfjig ludfjig added the kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. label Dec 10, 2024
@ludfjig ludfjig force-pushed the musl_subtree branch 9 times, most recently from d07b31f to 1c4344b Compare December 11, 2024 19:20
@ludfjig ludfjig marked this pull request as ready for review December 11, 2024 20:54
@ludfjig ludfjig mentioned this pull request Dec 11, 2024
@hyperlight-dev hyperlight-dev deleted a comment from hyperlight-prow bot Dec 17, 2024
Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but I mostly just reviewed 6fa239e)

Copy link
Contributor

@simongdavies simongdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment

@ludfjig ludfjig force-pushed the musl_subtree branch 2 times, most recently from 89a5969 to 99e9bc5 Compare December 17, 2024 22:31
@ludfjig ludfjig force-pushed the musl_subtree branch 5 times, most recently from 3e68f7f to d0b3095 Compare December 19, 2024 20:12
… 0784374d5

git-subtree-dir: src/hyperlight_guest/third_party/musl
git-subtree-split: 0784374d561435f7c787a555aeab8ede699ed298
Signed-off-by: Ludvig Liljenberg <[email protected]>
…light_guest/third_party/musl'

Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
@ludfjig ludfjig merged commit e79ec96 into hyperlight-dev:main Dec 19, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement For PRs adding features, improving functionality, docs, tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants