-
Notifications
You must be signed in to change notification settings - Fork 241
feat: batching events and webhook plugin support #1359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Enrique Lacal <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1359 +/- ##
========================================
Coverage 99.98% 99.98%
========================================
Files 315 315
Lines 21907 22036 +129
========================================
+ Hits 21903 22032 +129
Misses 2 2
Partials 2 2
|
|
PR not ready for review as I need to work on removing the |
fe72060 to
baccf3f
Compare
Signed-off-by: Enrique Lacal <[email protected]>
Signed-off-by: Enrique Lacal <[email protected]>
Signed-off-by: Enrique Lacal <[email protected]>
Signed-off-by: Enrique Lacal <[email protected]>
Signed-off-by: Enrique Lacal <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
…ebhooks Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
peterbroadhurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EnriqueL8 - looked great - I've filled in a couple of commits to simplify a bit of duplicate logic, and found an efficiency in deferring parsing of some data from string to JSON.
Also made the change to prevent creation of subscriptions with batching enabled, for event transports that don't support it.
|
Popped back to draft as there's a potential issue with creating subscriptions with the default transport |
Signed-off-by: Peter Broadhurst <[email protected]>
|
Tested the above fix from Peter and all good you can create a subscription with a transport and it defaults to web hooks |
Enable batching for subscriptions