Add more helpers around subscriptions and batch delivery #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awrichar
requested review from
dechdev,
nguyer and
peterbroadhurst
as code owners
Signed-off-by: Andrew Richardson <[email protected]>
While the strongly-typed interface is useful in most cases, it does not support some things, such as passing "id" multiple times in order to perform an "OR" query. Adding this to the "findData" API now since bulk fetching of data is a very common case - but we may want to consider adding it to all/most getters. Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Andrew Richardson <[email protected]>
awrichar
force-pushed
the
subscription
branch
from
6324c84 to
a2d3d29
Compare
nguyer
approved these changes
Feb 2, 2024
Contributor
nguyer
left a comment
nguyer
left a comment
There was a problem hiding this comment.
This looks good. Until this is available in a stable FireFly release, I would stick with a pre-release labelling of the SDK though.
This was referenced Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainline version of FireFly now supports batch delivery of events over websockets: hyperledger/firefly#1447
This PR adds support for consuming batched events, and adds a related option for calling "findData" to fetch all data related to a batch of messages.
Also adds a missing
getSubscriptionAPI (not a new feature, just missing).