Skip to content

Use Readable for return type of getDataBlob #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2023
Merged

Use Readable for return type of getDataBlob #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/firefly.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Stream, Readable } from 'stream';
import { Readable } from 'stream';
import * as http from 'http';
import * as FormData from 'form-data';
import * as WebSocket from 'ws';
Expand Down Expand Up @@ -225,9 +225,9 @@ export default class FireFly extends HttpBase {
return this.getMany<FireFlyDataResponse[]>(`/data`, filter, options);
}

async getDataBlob(id: string, options?: FireFlyGetOptions): Promise<Stream> {
async getDataBlob(id: string, options?: FireFlyGetOptions): Promise<Readable> {
const response = await this.wrapError(
this.http.get<Stream>(`/data/${id}/blob`, {
this.http.get<Readable>(`/data/${id}/blob`, {
...mapConfig(options),
responseType: 'stream',
}),
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@hyperledger/firefly-sdk",
"version": "1.2.8",
"version": "1.2.9",
"description": "Client SDK for Hyperledger FireFly",
"main": "dist/index.js",
"types": "dist/index.d.ts",
Expand Down Expand Up @@ -45,4 +45,4 @@
"form-data": "^4.0.0",
"ws": "^8.5.0"
}
}
}