Skip to content

Conversation

@m4sterbunny
Copy link
Contributor

@m4sterbunny m4sterbunny commented Sep 25, 2024

Description

Existing language implies that block number (an integer) is passed as a string, when its passed as hexadecimal

Fixes #1695

Preview

@m4sterbunny m4sterbunny requested a review from a team as a code owner September 25, 2024 17:43
@vercel
Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
besu-docs Ready Ready Preview Comment Nov 18, 2025 9:37am

Copy link
Contributor

@joaniekube joaniekube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@m4sterbunny m4sterbunny marked this pull request as draft October 1, 2024 06:49
@m4sterbunny m4sterbunny requested a review from joaniekube October 1, 2024 06:50
Signed-off-by: m4sterbunny <[email protected]>
…ms reintroduced by branch merge with main

Signed-off-by: m4sterbunny <[email protected]>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besu accepts either decimal or hex block numbers as parameters to RPCs.

it might be clearer to provide an example of each?

hex numbers must be prefixed with 0x otherwise it's assumed to be a decimal number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nitpicks

3 participants