-
Notifications
You must be signed in to change notification settings - Fork 133
proposes alt definition blockNumber #1696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: m4sterbunny <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: m4sterbunny <[email protected]>
Signed-off-by: m4sterbunny <[email protected]>
Signed-off-by: m4sterbunny <[email protected]>
joaniekube
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: m4sterbunny <[email protected]>
Signed-off-by: m4sterbunny <[email protected]>
…ms reintroduced by branch merge with main Signed-off-by: m4sterbunny <[email protected]>
macfarla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besu accepts either decimal or hex block numbers as parameters to RPCs.
it might be clearer to provide an example of each?
hex numbers must be prefixed with 0x otherwise it's assumed to be a decimal number
Description
Existing language implies that block number (an integer) is passed as a string, when its passed as hexadecimal
Fixes #1695
Preview