Skip to content

feat(transport): Add channel feature flag #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2022
Merged

feat(transport): Add channel feature flag #960

merged 2 commits into from
Apr 4, 2022

Conversation

@LucioFranco
Copy link
Member

@LucioFranco LucioFranco commented Apr 4, 2022

cc @djc

Closes #959

@LucioFranco LucioFranco requested a review from davidpdrsn April 4, 2022 18:38
djc
djc approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@LucioFranco LucioFranco merged commit f1ca90f into master Apr 4, 2022
@LucioFranco LucioFranco deleted the lucio/add-channel-feature branch April 4, 2022 19:31
@djc djc mentioned this pull request Apr 25, 2022
Closed
@djc djc mentioned this pull request Jun 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidpdrsn davidpdrsn Awaiting requested review from davidpdrsn

1 more reviewer

@djc djc djc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tonic provides no way to disable server-only dependencies

3 participants

@LucioFranco @djc