Endpoint::new Fixme comment

[elpiel]

Feature Request

As a user of the crate, I can say that the Endpoint::new() assoc. function is very handy.

Crates

tonic

Motivation

While the from_shared returns an InvalidUri error directly, the fn new() returns tonic::transport::Error.
When creating an endpoint I'd like to return tonic::transport::Error directly or use it to build my own error if needed.

Proposal

Unhide Entrypoint::new() from the docs.

Alternatives

Code

tonic/tonic/src/transport/channel/endpoint.rs

Lines 46 to 49 in debcafe

	// FIXME: determine if we want to expose this or not. This is really
	// just used in codegen for a shortcut.
	#[doc(hidden)]
	pub fn new<D>(dst: D) -> Result<Self, Error>

[LucioFranco]

I wonder if we should just change from_shared to return transport::Error?

[elpiel]

This will introduce a breaking change and the other impls should be changed as well TryFrom.
I think there is a case where you'd want to handle only the InvalidUri and use that in your API (e.g. a custom error) instead of tonic::transport::Error, however, in order to use the InvalidUri in your custom error you'd have to add the http crate as a dependency too.

Re-exporting InvalidUri & just making the new assoc. fn public is sufficient to me.

Side note: impl From<InvalidUri> for Error could also be useful to crate users. E.g. I currently use 1 endpoint that I pass to all generate services in my struct, however, I might want to create multiple endpoints for each service and still return a tonic::transport::Error