Skip to content

Conversation

@Urhengulas
Copy link
Contributor

This PR shall update tokio to version 0.3.

Changes

  • adapt AsyncRead, AsyncWrite implementations
  • rename delay_for -> sleep, Delay -> Sleep
  • ...

Fixes #2302


There are still quite some errors left to resolve, so I am happy to get some input there 😃

Comment on lines +58 to +59
// TODO: There should be a way to do following two lines cleaner...
buf.put_slice(prefix.to_vec().as_slice());
Copy link
Contributor

@paolobarbolini paolobarbolini Oct 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix it

Suggested change
// TODO: There should be a way to do following two lines cleaner...
buf.put_slice(prefix.to_vec().as_slice());
buf.put_slice(&prefix[..copy_len]);

@seanmonstar
Copy link
Member

Thanks for this! I had also started a branch just yesterday doing this, which was useful to find all the things that aren't easily fixable in hyper, and started trying to put them back into Tokio. The biggest one is vectored writes, but there's a few smaller things too. I'll list them in the original issue.

@Urhengulas
Copy link
Contributor Author

@seanmonstar: Thanks for this! I had also started a branch just yesterday doing this, which was useful to find all the things that aren't easily fixable in hyper, and started trying to put them back into Tokio. The biggest one is vectored writes, but there's a few smaller things too. I'll list them in the original issue.

Sounds like a good plan 😁

@hawkw hawkw mentioned this pull request Oct 29, 2020
@seanmonstar
Copy link
Member

Thanks for starting this! Eliza did most of the rest in #2317, and the one last tweak was finished in #2319.

@seanmonstar seanmonstar closed this Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to Tokio v0.3

3 participants