feat(client): Implement TryFrom for Destination #1810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add TryFrom<Uri> impl for Destination, for compiler version >= 1.34. Add basic unit tests for TryFrom impl Ref Issue: Implement TryFrom for Destination hyperium#1808
Add #[cfg(try_from)] to TryFrom import. Ref Issue; hyperium#1808
seanmonstar
reviewed
May 9, 2019
src/client/connect/mod.rs
Outdated
| fn try_from(uri: Uri) -> Result<Self, Self::Error> { | ||
| uri.authority_part().ok_or(::error::Parse::Uri)?; | ||
| uri.scheme_part().ok_or(::error::Parse::Uri)?; | ||
| Ok(Destination { uri }) |
There was a problem hiding this comment.
I believe this can just call Destination::try_from_uri internally.
Change TryFrom<Uri> for Destination to use Destination's internal try_from_uri method. Ref Issue: hyperium#1808
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TryFrom impl for Destination, for compiler version >= 1.34.
Add basic unit tests for TryFrom impl
Ref Issue: Implement TryFrom for Destination #1808