Add StatusCode::EARLY_HINTS and TOO_EARLY constants #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seanmonstar This PR is very trivial and shouldn't take much time to review |
robjtede
approved these changes
Apr 30, 2022
robjtede
left a comment
robjtede
left a comment
There was a problem hiding this comment.
I think being on the IANA list is a good enough candidacy requirement despite these being "experimental" RFCs.
Comment on lines
-19
to
+40
| fn equates_with_u16() { | ||
| fn partial_eq_ne() { | ||
| let status = StatusCode::from_u16(200u16).unwrap(); | ||
| assert_eq!(200u16, status); | ||
| assert_eq!(status, 200u16); | ||
| assert_ne!(status, 201u16); | ||
| assert_ne!(status, 0u16); |
There was a problem hiding this comment.
Everything in this file strikes me as detritus from #451.
Member
|
Sorry this languished. I agree, being "Proposed Standards" is a good time to support it. I lean towards merging some of these things individually, so I merged the oldest PR with just EARLY HINTS (#758). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
StatusCodedocs imply full coverage of IANA status codes and these two were added after the original implementation.Its a highly safe change, but I'd wait for 1.0.0, treating it more like a new feature.
Closes #439