Skip to content

Conversation

heusalagroupbot
Copy link
Collaborator

Adds scripts as a submodule and brings in .github/workflows/ci.yml. Scope: scripts/ and CI only. Risk: low; no product code. Tests: CI runs 'make tidy lint test build build-tools' matrix; local shellcheck optional. Tracking: FEATURE_CHECKLIST.md line 'Slice PR — scripts and gh utilities'.

heusalagroupbot pushed a commit that referenced this pull request Aug 19, 2025
Copy link
Contributor

@thejhh thejhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@thejhh
Copy link
Contributor

thejhh commented Aug 20, 2025

Let's disable CI rules until we get them fixed.

Copy link
Contributor

@thejhh thejhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's disable CI rules until they will be fixed

@thejhh
Copy link
Contributor

thejhh commented Aug 20, 2025

Instead of disabling, you could also create a new PR for CI rules and remove CI rules from this one.

Copy link
Contributor

@thejhh thejhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to create a PR and branch for the ci workflow. Then remove that code from this branch.

@heusalagroupbot
Copy link
Collaborator Author

Per admin feedback:

  • Extracted CI workflow into a separate draft PR (CI workflow: add disabled-by-default pipeline (manual-only) #57) with triggers disabled; manual-only via workflow_dispatch for now.
  • Removed from this branch to keep scope limited to scripts.
  • Rebased onto latest and force-pushed with lease to update the branch after the rebase.

If any additional CI adjustments are desired in #57, I’ll handle them there while keeping this PR focused.

Copy link
Contributor

@thejhh thejhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now

@thejhh thejhh marked this pull request as ready for review August 20, 2025 20:37
@thejhh thejhh merged commit d7394e0 into main Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants