Skip to content

Conversation

@omkar-334
Copy link
Contributor

@omkar-334 omkar-334 commented Nov 18, 2025

What does this PR do?

Fixes # (issue)
#42180 partially
@Rocketknight1

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@omkar-334
Copy link
Contributor Author

omkar-334 commented Nov 18, 2025

@Rocketknight1 should I use the relative URL only? if so, is this the right path - ../generation_strategies ?

The documentation URL - http://huggingface.co/docs/transformers/model_doc/whisper
Old Generation Strategies URL - https://huggingface.co/docs/transformers/model_doc/generation_strategies
New URL - https://huggingface.co/docs/transformers/en/generation_strategies

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Rocketknight1
Copy link
Member

@omkar-334 I think (../generation_strategies) is right, but feel free to try it and I can rerun the doc build job to check

Updated the link to the generation strategies guide in the docstring.
@omkar-334
Copy link
Contributor Author

hey @Rocketknight1 , I've changed the url to relative. Can you run the doc build? If it doesn't work, i'll just change it back

@Rocketknight1
Copy link
Member

@omkar-334 build started!

@omkar-334
Copy link
Contributor Author

hey @Rocketknight1 , the fix is working. Thanks! you may merge this now

@github-actions
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: whisper

@Rocketknight1
Copy link
Member

Merging!

@Rocketknight1 Rocketknight1 enabled auto-merge (squash) November 20, 2025 17:08
@Rocketknight1 Rocketknight1 merged commit 7b84f72 into huggingface:main Nov 20, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants