Check model inputs - hidden states #40994
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #40964
In most vision models the
output.hidden_states
are the hiddens right after encoder blocks, i.e. before the last layernorm. Therefore for these modelsoutput.hidden_states != output.last_hidden_state
Currently
check_model_inputs
assumes that last hidden state is the correct one to return which is true for language models only. This PR adds a kwarg forcheck_model_inputs
which decides whether to replace last hidden state or notTBH, i think the way it is done in LMs is the ultimate correct version and we probably need to "break" vision models. But I can't think of a way to obtain pre-norm last hidden states which are needed for some VLMs