Hub package compatible with StrictConcurrency #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrkowalczuk
force-pushed
the
sendable-downloader
branch
2 times, most recently
from
c0f0ef2 to
53bfa0b
Compare
piotrkowalczuk
force-pushed
the
sendable-downloader
branch
from
d19db90 to
49a760d
Compare
Contributor
Author
|
I believe this PR is now ready for review. //cc @FL33TW00D |
piotrkowalczuk
changed the title
Contributor
|
Hey @piotrkowalczuk, |
Contributor
Author
|
@FL33TW00D done |
piotrkowalczuk
force-pushed
the
sendable-downloader
branch
from
f6304af to
8de7f49
Compare
Contributor
|
Sorry for the delay here @piotrkowalczuk, I've had to call in the big guns (@pcuenca) to review this one. |
Contributor
Author
|
Friendly reminder 😄 |
Contributor
|
@piotrkowalczuk sorry for the delay here, thank you for the fantastic work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up for #189 and is related to #172. It changes the remaining parts of the Hub package to be compatible with structured concurrency. As a result:
Downloader,LanguageModelConfigurationFromHubandHubApiconform to theSendableprotocol.Broadcaster<E: Sendable>got added as a building block replacingCurrentValueSubject.Package.swiftthat enable selective support forStrictConcurrencytoHubandHubTestspackages.Relevant changes to this PR are located in
Source/Hub/Hub,Source/Hub/HubApi,Tests/HubTests/DownloaderTests.swiftandPackage.swift.