Skip to content

Fix punctuation in average embedding #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix punctuation in average embedding #337

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41b15ff
Fix punctuation in average embedding
valedica Mar 11, 2022
9016065
Add doc embeddings calculation during inference
valedica Mar 11, 2022
11215dc
Revert "Add doc embeddings calculation during inference"
valedica Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion neuralcoref/neuralcoref.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,7 +893,7 @@ cdef class NeuralCoref(object):
cdef int n = 0
embed_arr = numpy.zeros(self.static_vectors.shape[1], dtype='float32')
for token in span:
if token.lower not in PUNCTS:
if not inside(token.lower, self.hashes.puncts):
n += 1
embed_vector = self.get_word_embedding(token, tuned=False)
embed_arr = embed_arr + embed_vector
Expand Down