Skip to content

[vLLM Snippet] update #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2024
Merged

[vLLM Snippet] update #942

merged 1 commit into from
Oct 4, 2024

Conversation

mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Oct 4, 2024 •
edited
Loading

Follow up to #693

  1. Add missing comma
  2. Add line splitter between two commands
Screenshot 2024-10-04 at 14 52 09

@mishig25 mishig25 merged commit e302a1b into main Oct 4, 2024
5 checks passed
@mishig25 mishig25 deleted the update_vllm_snippet branch October 4, 2024 13:02
@mishig25 mishig25 mentioned this pull request Oct 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gary149 gary149 gary149 approved these changes

@osanseviero osanseviero Awaiting requested review from osanseviero

@SBrandeis SBrandeis Awaiting requested review from SBrandeis SBrandeis is a code owner

@Wauplin Wauplin Awaiting requested review from Wauplin Wauplin is a code owner

@julien-c julien-c Awaiting requested review from julien-c julien-c is a code owner

@pcuenca pcuenca Awaiting requested review from pcuenca pcuenca is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mishig25 @gary149