Fix loading sharded checkpoints when we have variants #9061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
reviewed
Aug 2, 2024
sayakpaul
reviewed
Aug 2, 2024
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Thank you! Just left a comment.
Member
|
@yiyixuxu could you give this another look? Important to get in I believe. |
…ers into shard-loading-variant
yiyixuxu
approved these changes
Aug 6, 2024
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
* Fix loading sharded checkpoint when we have variant * add test * remote print --------- Co-authored-by: Sayak Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR fixes an issue with loading variants. We pass the
index_fileinstead of the directory when we have a sharded checkpoint. Passing the directory entrust accelerate to find the right file. It will be better for the future to pass the right file directly! This enables us to load variants within a same repository.Fixes huggingface/accelerate#2946