Skip to content

Conversation

jiagaoxiang
Copy link
Contributor

@jiagaoxiang jiagaoxiang commented Jul 10, 2024

Enable VAE hash to be able to change with args change. If not, train_dataset_with_embeddings may have row number inconsistency with train_dataset_with_vae. This bug will happen when we change the args. In this situation, train_dataset_with_vae will retrieve the cached data with the old hash value; while train_dataset_with_embeddings will do new calculations with the new hash values. This will cause mismatch.

What does this PR do?

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Enable VAE hash to be able to change with args change. If not, train_dataset_with_embeddiings may have row number inconsistency with train_dataset_with_vae.
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Sep 14, 2024
@yiyixuxu yiyixuxu requested a review from linoytsaban November 16, 2024 21:54
@yiyixuxu yiyixuxu removed the stale Issues that haven't received updates label Nov 16, 2024
Copy link
Collaborator

@linoytsaban linoytsaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jiagaoxiang! @yiyixuxu should we maybe add a small test here?

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Dec 16, 2024
@linoytsaban linoytsaban removed the stale Issues that haven't received updates label Dec 30, 2024
@linoytsaban
Copy link
Collaborator

@yiyixuxu safe to merge I think?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yiyixuxu yiyixuxu merged commit f7822ae into huggingface:main Jan 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants