Add decorator for compile tests #8703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
approved these changes
Jun 26, 2024
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Thanks! Could you also confirm if the compile tests are running successfully on our T4 CI runner? Related: pytorch/pytorch#129351.
Collaborator
Author
|
They're not unfortunately. Will look into that issue separately. |
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
* update * update --------- Co-authored-by: Sayak Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Compile tests originally only ran on Python 3.9, but since our default is 3.10, they're running inside the other test runner jobs in addition to their dedicated runner.
This PR introduces an
is_torch_compiledecorator similar toslowfor the compile tests. The compile tests will only run when aRUN_COMPILEenv variable is set. This ensures that the compile tests run in their own module.Also removes the
requires_python39higher check as it's no longer needed.Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.