-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(DDIM scheduler): use correct dtype for noise #742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DDIM scheduler): use correct dtype for noise #742
Conversation
Otherwise, it crashes when eta > 0 with float16.
|
Should we add a right now the different calls to randn are subtly inconsistent in whether and how they pass dtype or device. Having a single implementation would provide one place for those fiddly details, especially if there are things that have to be different on certain platforms like |
|
The documentation is not available anymore as the PR was closed or merged. |
a) this is not an informative failure message. sod off, stylebot. |
pcuenca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
I think that makes sense, and we should ensure that all calls use the generator. If @patrickvonplaten and @anton-l agree we can follow up in a new PR :) |
|
I think this fix can potentially be applied to sde-ve and sde-vp schedules too |
patrickvonplaten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fix! Thanks!
Otherwise, it crashes when eta > 0 with float16.
…ce#742) Co-authored-by: dan <[email protected]> Co-authored-by: powderluv <[email protected]>
Otherwise, it crashes when eta > 0 with float16.
Otherwise, it crashes when eta > 0 with float16.
Follow-up to #511.