Skip to content

Conversation

@mariopenglee
Copy link

What does this PR do?

In accordance to the deprecation message:
deprecate("steps_offset!=1", "1.0.0", deprecation_message, standard_warn=False) is outdated.
"steps_offset should be set to 1 instead of 0. Please make sure to update the config accordingly as leaving steps_offset might led to incorrect results in future versions. If you have downloaded this checkpoint from the Hugging Face Hub, it would be very nice if you could open a Pull request for the scheduler/scheduler_config.json file"

I changed the default value to 1 and edited the documentation to reflect the changes.

Before submitting

Who can review?

@yiyixuxu

In accordance to the deprecation message: 
deprecate("steps_offset!=1", "1.0.0", deprecation_message, standard_warn=False)
is outdated. `steps_offset` should be set to 1 instead of 0. Please make sure to update the config accordingly as leaving `steps_offset` might led to incorrect results in future versions. If you have downloaded this checkpoint from the Hugging Face Hub, it would be very nice if you could open a Pull request for the `scheduler/scheduler_config.json` file
@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Mar 9, 2024

hey! thanks for the PR but we cannot accept it
that deprecation message is sent only from SD pipelines - changing the default will break some other pipelines when using this scheduler

this is somewhat related #7128

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Issues that haven't received updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants