Skip to content

Fix formula for noise levels in Karras scheduler and tests #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2022
Merged

Fix formula for noise levels in Karras scheduler and tests #627

merged 1 commit into from
Sep 24, 2022

Conversation

@sgrigory
Copy link
Contributor

@sgrigory sgrigory commented Sep 23, 2022

Closes #590

  • Add missing square into the formula for noise levels in Karras schedulers (torch and flax versions), so that now it's aligned with the paper (VE column of Table 1)
  • Adjust tests

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 23, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@sgrigory sgrigory marked this pull request as ready for review September 23, 2022 20:26
@sgrigory sgrigory mentioned this pull request Sep 23, 2022
Closed
@kashif kashif self-requested a review September 24, 2022 08:43
kashif
kashif approved these changes Sep 24, 2022
View reviewed changes
Copy link
Contributor

@kashif kashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks

anton-l
anton-l approved these changes Sep 24, 2022
View reviewed changes
Copy link
Member

@anton-l anton-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed locally, thank you for the fix @sgrigory!

@anton-l anton-l merged commit 35e9209 into huggingface:main Sep 24, 2022
prathikr pushed a commit to prathikr/diffusers that referenced this pull request Oct 26, 2022
@sgrigory
Fix formula for noise levels in Karras scheduler and tests (huggingfa…
9bd5f62 
…ce#627)

fix formula for noise levels in karras scheduler and tests
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@sgrigory
Fix formula for noise levels in Karras scheduler and tests (huggingfa…
4ba8b10 
…ce#627)

fix formula for noise levels in karras scheduler and tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kashif kashif kashif approved these changes

@anton-l anton-l anton-l approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typo in noise level formula in Karras scheduler

4 participants

@sgrigory @HuggingFaceDocBuilderDev @kashif @anton-l